Upgrade Commoner to v0.8.14 for multiple file support #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [Commoner's README.md]( https://github.com/benjamn/commoner#generating-multiple-files-from-one-source-module) for further explanation of the new functionality. Among other potential benefits, this upgrade allows us to generate source maps as standalone files rather than appending them inline to every compiled module file under `build/modules/` (see facebook#833).
|
👍 feel free to just push it |
benjamn
added a commit
that referenced
this pull request
Jan 23, 2014
Upgrade Commoner to v0.8.14 for multiple file support.
This was referenced Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commoner's README.md for further explanation of the new functionality.
Among other potential benefits, this upgrade allows us to generate source maps as standalone files rather than appending them inline to every compiled module file under
build/modules/(see #833).The
commonerConfig.versionbump isn't strictly necessary, but it seems like a good idea whenever we change the way Commoner works internally.cc @andrewdavey @zpao